PR #11281 — fix failing CI (E2E + DeepSource JS-W1015)

completed

Priority: 1

Branch: carson/BOLT-597-sso-phase-3-cleanup

PR: #11281

Carson asked me to look at failing checks on PR #11281 (carson/BOLT-597-sso-phase-3-cleanup). Failures: - E2E (Playwright): @texturehq/edges/dist/theme.css missing on cache-hit because node_modules cache does not include workspace dist artifacts and postinstall (build:workspace-packages) is skipped. Fix: explicit yarn turbo run build --filter=@texturehq/edges step in test-e2e job before tests. - DeepSource JS-W1015 in apps/auth/src/components/BrandLogo/index.tsx (use next/image). Fix: add // skipcq: JS-W1015 next to existing biome-ignore (SVG, no optimization needed). - Deploy onboard: Vercel npm-auth flake (Invalid authentication), infra/transient — NOT addressed. - DeepSource test-coverage: 31 introduced (new files: layout.tsx, BrandLogo, GrowthBookProvider, postcss.config.mjs). NOT addressed in this fix — surfacing to Carson to decide whether to add tests or accept.

Event Timeline

created

progress

Added 15 focused auth tests covering BrandLogo, GrowthBookProvider, loadGrowthBookFeatures, Providers, and RootLayout; excluded .mjs config from coverage. Local targeted tests/typecheck pass; full auth coverage run passed before rebase; pushed 4363baabbd and watching CI.

progress

DeepSource JS apps/auth run 4c924635 still failed on JS-W1042 in src/lib/growthbook.test.ts (redundant undefined mock). Rebased onto remote c8a627c876, changed mock to return null via implementation, verified typecheck + targeted tests + lint (existing warning only), pushed 7db5b86a26.

progress

DeepSource run 4a091fb0 failed JS-W1042 in growthbook.test.ts and coverage on LoginPageLayout.tsx. Added LoginPageLayout tests and changed undefined mock to null implementation. Verified typecheck, targeted tests, lint (existing warning only), and full auth coverage (79 files/1239 tests passed). Pushed 0dc5829cdf.

progress

Heartbeat CI check: all code-related checks on PR #11281 are green (DeepSource JS/coverage apps/auth+dashboard, E2E, lint, typecheck, unit tests). Only failing check is deploy / Deploy onboard, failing inside Vercel preview yarn install with GitHub Packages Invalid authentication for private @texturehq packages; reran failed job 26599423536 as infra/transient credentials issue and continuing to watch.

progress

Addressed Carson review: bounded server-side GrowthBook loadFeatures with {timeout: 2000}; updated loadGrowthBookFeatures test to assert timeout. Verified typecheck, targeted tests, lint (existing warning only). Pushed 547e3ab705.

status_change

in_progress → completed