Address CI and review feedback on PR #13821 (BOLT-1694)
completedSlava explicitly requested fixes for PR #13821 / BOLT-1694 on branch BOLT-1694/domains-device. Inspect all failing CI logs plus Cursor/CodeRabbit/human review threads; repair valid issues directly on Slava-owned branch. Use a dedicated worktree, set required git identity, run domains/device lint before each push, commit with Co-authored-by: Slava <[email protected]>, push, monitor CI to green, resolve addressed threads. Do not merge.
Event Timeline
created
progress
Pushed b316a0f to BOLT-1694/domains-device: adds missing AWS_S3_EXTERNAL_ID config, updates event-bus to 10.33.0 (meter device.discovered arm), and applies device Biome formatting. domains/device lint, typecheck, and 4 targeted suites (23 tests) pass locally. CI and CodeRabbit are now being watched.
progress
Pushed d7e0e6b to PR #13821. Fixed all scope-contained CodeRabbit issues: psql credentials leave argv, stream cleanup/backpressure/error handling, exit cleanup, scoped AWS session tokens/errors, resume/skip guards, S3 DuckDB safety, admin validation, meter interval preservation, and date-window coverage. Local device lint + typecheck + 4 targeted suites pass (32 tests). CI/re-review now watched.
progress
Pushed 8613e02 to PR #13821. Addressed the remaining valid CodeRabbit finding with a persistent series_map write-stream error listener. Also incorporated upstream branch/main advancement plus locally verified fixes for the prior lint/type regressions. CI is re-running; no merge performed.
progress
Post-push verification complete after refreshing private package auth: device lint and typecheck pass; focused SMT/createDevice Jest suites pass (33 tests). Waiting for PR #13821 CI and CodeRabbit review.
progress
CI failure isolated to Knip: duplicate exported S3 credential resolver. Removed unused deprecated alias and pushed 6c4ccd8. Local lint, Knip, typecheck, and focused SMT/createDevice suites pass (33 tests). CI/re-review now watched.
progress
Pushed 798f2b8 addressing all newly surfaced CodeRabbit process-handling findings: child stdin EPIPE handling and docker fallback restricted to missing psql binary. Resolved the covered review threads. Local lint, Knip, typecheck, and focused suites pass (33 tests). CI re-running.
status_change
in_progress → completed