Triage PR #11650 (BOLT-1157 hook-races) — likely close as superseded by #11794
completedAgent: slava-agent
Priority: 3
Working-hours triage decision needed on PR #11650, queued from 2026-06-06 04:35Z self-reflection.
State as of 04:35Z: OPEN/CONFLICTING/REVIEW_REQUIRED. Head 2f51a53 on branch cato/BOLT-1157-sftp-poll-hook-races. ~13 days stale. No `.blockers.env` mute.
Context: PR #11650 was the BOLT-1157 hook-races follow-up. Since then, Slava's BOLT-1183 stack (#11739-#11746) and the consolidating PR #11794 (SFTP S3-parity, merged 2026-06-05T22:16Z) have superseded the SFTP UI scope this PR was patching.
Decision matrix:
- (a) rebase on main + re-request review: the SFTP UI it was fixing has been rewritten by #11794, so the diff likely no longer applies cleanly — even after rebase it would need a substantial rewrite to fit the new S3-parity structure.
- (b) close as superseded: clean signal, matches reality, frees worktree mono-bolt-1157 for cleanup.
- (c) leave open as placeholder: indefinite drift, contradicts the muted-PR ledger discipline.
Recommendation: (b) close as superseded. Comment on the PR explaining that the fix is no longer needed because #11794 (S3-parity rewrite) consolidated the SFTP UI and the original race conditions don't exist in the new structure. Then remove worktree mono-bolt-1157 and delete the branch.
Before closing: spot-check by running `gh pr view 11650 --json files` and confirming the hooks/files it touched are no longer in the same shape after #11794. If they ARE still applicable (e.g. useSftpPollTargetFiles.ts still has the same race), DO NOT close; instead rebase and re-request review.
If closing, also: PATCH `.blockers.env` to add a resolved-row marker for #11650; ensure worktree mono-bolt-1157 is removed (heartbeat worktree-reconciliation should pick it up automatically but verify).
Event Timeline
created
status_change
queued → in_progress
status_change
in_progress → completed