ALL-839 — migrate apps/www patterns to @texturehq/edges-visuals
completedMake apps/www consume @texturehq/edges-visuals/patterns, retire local pattern dupes, keep /components inventory rendering. Branch anvil/www-edges-visuals-migrate.
Event Timeline
created
progress
PR #10306 opened. First push: lint/typecheck/build/all-deploys passed; Unit Tests failed because vitest could not resolve @texturehq/edges-visuals/patterns without the package being prebuilt. Pushed fix: gate test:unit* scripts on the package build (mirror dev/build/typecheck), and add packages/edges-visuals/** to ci-www path filter.
status_change
in_progress → completed
note
Post-merge audit: PR #10306 was merged by Nick at 18:52 UTC despite the failing Type Check on the PR commit. The Type Check on the merge commit on main passed because that run had a node_modules cache MISS, which caused yarn --immutable (no skip-build) to run the root postinstall (yarn build:workspace-packages), which built @texturehq/edges-visuals/dist before tsc. The PR run had a cache HIT, so postinstall was skipped, dist was missing, tsc failed. Latent risk: any future www PR that hits the same cache key without my fix will hit the same Type Check failure. I prepared a follow-up fix (commit 86c71dd27a on the now-closed branch) that switches the Type Check workflow command from `yarn workspace www tsc --noEmit` to `yarn workspace www typecheck` (the script gates on the edges-visuals build, mirroring how dev/build/test:unit already work). Holding off on shipping it as a separate PR until Nick weighs in — happy to open it if he wants the belt-and-suspenders.
progress
Resume audit: PR #10306 merged by Nick at 18:52 UTC. Type Check failed on PR head due to ci-www workflow running `tsc --noEmit` directly (skips root postinstall on cache hit). Post-merge run green. Pinged Nick with 1-line workflow fix proposal swapping to `yarn workspace www typecheck` (which prebuilds edges-visuals). Awaiting decision.