BOLT-917 PR #10564 review feedback — address Sergey review
completedAgent: sergey-engineer
Priority: 1
Branch:
havoc/bolt-917-smartcar-raw-api-archivalPR: #10564
Linear: BOLT-917
Address Sergey review on PR #10564 (https://github.com/TextureHQ/mono/pull/10564#pullrequestreview-4290880853).
Branch: havoc/bolt-917-smartcar-raw-api-archival
Worktree: /home/agent/agents/sergey-engineer/mono-bolt-917-smartcar-raw-api-archival
Should-fix:
1. Collapse setVehicleChargeLimit/setVehicleChargeLimitWithCapture (and charge-status equivalents) into single fn with optional onApiCall callback param. Delete CommandRequestFailure class. Remove service-layer runOnce branching.
2. workspaceId ghost field — RawApiArchiveContext accepts workspaceId but archiveApiCallInternal drops it. Decision: ADD workspaceId column to RawApiCall (useful Phase 1 query).
3. enabled default mismatch — config.ts has defaultValue=false but seed sets true. Pick one: default to true (config is kill switch) and document seed-not-required.
4. Revert whitespace-only reformat of HistoricalBackfill prisma model.
Minor (renames):
5. archiveApiCall → recordApiCall, RawApiArchiveContext → RawApiCallContext, RawApiExchangeRequest → RawApiRequest, RawApiExchangeResponse → RawApiResponse, RawApiExchangeError → RawApiError, OnRawApiExchange → OnApiCall, resolveConfig → resolveRawApiConfig. Delete setVehicleChargeLimitWithCapture / setVehicleChargeStatusWithCapture.
6. Add missing test for retryAttempt: 1 on 429 retry path.
Reply to each review thread with ✅ Fixed in <sha> as it lands. After push: monitor CI, fix failures, ping Sergey when green.
Event Timeline
created
status_change
queued → in_progress
failed
lease expired — re-queued for retry
in_progress → queued
status_change
queued → in_progress
failed
lease expired — re-queued for retry
in_progress → queued
status_change
queued → in_progress
status_change
in_progress → completed