BOLT-810: revive PR #12937 device-type-aware program event actions
completedAgent: richie-engineer
Priority: 1
Branch:
rcasto/bolt-810-dashboard-device-typePR: #12937
Linear: BOLT-810
Richie asked 2026-07-28 to take over stale PR #12937. Validate and address unresolved Cursor/Codex/CodeRabbit feedback (mixed battery/charger batch type preservation, selector hydration/reconciliation, shared eligibility helper, drawer form reset), rebase onto current main, validate, push safely to rcasto/bolt-810-dashboard-device-type, and monitor CI. Linear BOLT-810.
Event Timeline
created
progress
Validated PR #12937 feedback: all five unresolved findings are still valid, including three P1/P2 variants of global battery fallback overwriting charger/mixed batches. Branch is 2,637 commits behind current main. I am rebasing first, then will implement the per-batch config/targeting fix plus shared eligibility helper and drawer hydration reset on the refreshed branch.
progress
Rebased PR #12937 from 2,637 commits behind current main and pushed review remediation. All unresolved Cursor/Codex/CodeRabbit reports were valid: preserve each mixed batchs persisted slug/config/eligible targets during propagation and editing; hydrate selector from persisted batch slug; centralize charger-aware eligibility in the config module; reset drawer defaults before hydration. Local dashboard lint, focused 23-test suite, dashboard typecheck, and diff check pass. CI watch active.
failed
lease expired — re-queued for retry
in_progress → queued
progress
CI found legitimate Knip failures from stale battery-only exports left after helper consolidation. Removed superseded payload/slug/eligibility exports, moved remaining import/test consumers to deviceTypeCommandConfig, and pushed follow-up. Local lint, dashboard typecheck, Knip, diff check, and 34 focused tests pass. CI watch remains active.
status_change
queued → in_progress
failed
lease expired — re-queued for retry
in_progress → queued
progress
Diagnosed all 30 DeepSource coverage findings: 27 were the untestable Apollo mutation wrapper after removing obsolete exports, 3 were the React-Aria drawer integration surface, and the remaining config branch lacked coverage. Added direct coverage for missing command-config paths, documented narrow exclusions for the Apollo/portal surfaces, and pushed 55959927f2. Focused 36-test suite and Biome pass; CI restarted.
progress
Resolved all five previously-unresolved Cursor, Codex, and CodeRabbit review threads after verifying their fixes on current head; replies point to 5c9eeb4db1. CI is watching the DeepSource coverage repair at 55959927f2.
status_change
queued → blocked
status_change
blocked → completed